Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fail insert when primary vindex cannot be mapped to a shard #15500

Merged
merged 1 commit into from
Mar 20, 2024
Merged

fail insert when primary vindex cannot be mapped to a shard #15500

merged 1 commit into from
Mar 20, 2024

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Mar 15, 2024 •
edited
Loading

Description

This PR fails the insert ignore or insert on duplicate key query when the row cannot be mapped to a shard.
Earlier we used to ignore the row and continue but that confuses the users as not mapping a row to a shard is a non-ignorable error.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 15, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Mar 15, 2024
@vitess-bot vitess-bot bot mentioned this pull request Mar 15, 2024
Merged
@harshit-gangal harshit-gangal added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Mar 15, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Mar 15, 2024
@harshit-gangal harshit-gangal added Type: Bug and removed Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Mar 15, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.66%. Comparing base (d1d1901) to head (afa251d).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #15500   +/-   ##
=======================================
  Coverage   65.65%   65.66%           
=======================================
  Files        1563     1563           
  Lines      194414   194422    +8     
=======================================
+ Hits       127640   127658   +18     
+ Misses      66774    66764   -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harshit-gangal harshit-gangal marked this pull request as ready for review March 18, 2024 04:58
GuptaManan100
GuptaManan100 approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshit-gangal harshit-gangal merged commit b164a6e into vitessio:main Mar 20, 2024
116 checks passed
@harshit-gangal harshit-gangal deleted the insert-dup-fix branch March 20, 2024 09:13
@GrahamCampbell
Copy link
Contributor

Should this be backported?

GrahamCampbell pushed a commit to GrahamCampbell/vitess that referenced this pull request Mar 26, 2024
@harshit-gangal @GrahamCampbell
fail insert when primary vindex cannot be mapped to a shard (vitessio…
206b039 
…#15500)

Signed-off-by: Harshit Gangal <[email protected]>
@GrahamCampbell GrahamCampbell mentioned this pull request Mar 26, 2024
Merged
5 tasks
harshit-gangal added a commit that referenced this pull request Mar 26, 2024
@GrahamCampbell @harshit-gangal
[release-19.0] Fail insert when primary vindex cannot be mapped to a …
3ce8f87 
…shard (#15500) (#15573)

Signed-off-by: Harshit Gangal <[email protected]>
Co-authored-by: Harshit Gangal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@dbussink dbussink dbussink approved these changes

@systay systay Awaiting requested review from systay systay is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Bug
Projects
None yet
Milestone
v20.0.0
Development

Successfully merging this pull request may close these issues.

excute query "insert on duplicate key update" reports ok but actually not executed
4 participants
@harshit-gangal @GrahamCampbell @dbussink @GuptaManan100